Skip to content

Adjust rbac to match mcad #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jbusche
Copy link
Collaborator

@jbusche jbusche commented Sep 12, 2023

Issue link

Closes #187

What changes have been made

Adjusts the mcad_controller.go rbac rules to match the recent changes with MCAD in PR project-codeflare/multi-cluster-app-dispatcher#475

Verification steps

Did a make image-build and deployed it, looked good.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • [x ] Manual tests
    • Testing is not required for this change

Checked the resulting rbac rules and they looked right. Left out the xqueuejobs as per @astefanutti suggestion.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: James Busche <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Sep 12, 2023
@jbusche
Copy link
Collaborator Author

jbusche commented Sep 12, 2023

Testing looks good - clusterrole looks complete on my test system:

make image-build -e IMAGE_TAG_BASE=quay.io/jbusche/pr187 VERSION=rc5
make image-push -e IMAGE_TAG_BASE=quay.io/jbusche/pr187 VERSION=rc5
make deploy -e IMG=quay.io/jbusche/pr187:rc5
oc get clusterrole codeflare-operator-manager-role -o yaml
...
- apiGroups:
  - quota.codeflare.dev
  - workload.codeflare.dev
  resources:
  - appwrappers
  - appwrappers/finalizers
  - appwrappers/status
  - queuejobs
  - quotasubtrees
  - schedulingspecs
  verbs:
  - create
  - delete
  - deletecollection
  - get
  - list
  - patch
  - update
  - watch

And then the deploy of the codeflare kfdef looked good:

oc get pods |grep 136m
instascale-instascale-6bbccb5c8f-7xm9w                            1/1     Running   0          136m
kuberay-operator-b697b6d6d-shv7z                                  1/1     Running   0          136m
mcad-controller-mcad-89cbf885d-sfw8m                              1/1     Running   0          136m

And the guided sample deployed ok:

oc get pods -n default
NAME                                       READY   STATUS    RESTARTS   AGE
raytest-head-8pkk4                         1/1     Running   0          125m
raytest-worker-small-group-raytest-gthc2   1/1     Running   0          125m
raytest-worker-small-group-raytest-wgtz8   1/1     Running   0          125m

Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 86b35a4 into project-codeflare:main Sep 13, 2023
@jbusche jbusche deleted the jb-187-quotatree2 branch September 13, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the operator kubebuilder mcad roles for quota trees PR
4 participants