-
Notifications
You must be signed in to change notification settings - Fork 59
Adjust rbac to match mcad #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust rbac to match mcad #283
Conversation
Signed-off-by: James Busche <[email protected]>
Signed-off-by: James Busche <[email protected]>
Testing looks good - clusterrole looks complete on my test system:
And then the deploy of the codeflare kfdef looked good:
And the guided sample deployed ok:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue link
Closes #187
What changes have been made
Adjusts the mcad_controller.go rbac rules to match the recent changes with MCAD in PR project-codeflare/multi-cluster-app-dispatcher#475
Verification steps
Did a make image-build and deployed it, looked good.
Checks
Checked the resulting rbac rules and they looked right. Left out the xqueuejobs as per @astefanutti suggestion.