Upgrade to go 1.20 and update required dependencies + point to compatible MCAD #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianZaccaria
changed the title
|
/hold until this PR is merged: project-codeflare/multi-cluster-app-dispatcher#697 and I have updated the CFO to point to that branch. |
2 tasks
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/unhold all tests are now passing. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes have been made
Updating the codeflare-operator's dependencies and go version to 1.20 to solve a High CVE.
There is a single function used by MCAD where the signature is changed due to these updated dependencies, causing conflicts and errors. This PR will also point the CFO to use the newly created branch in MCAD with the updated dependencies and signature updates.
PR in MCAD repo to be merged in a new branch named
go-1.20and to be consumed by the CFO: project-codeflare/multi-cluster-app-dispatcher#697Verification steps
Checks