Skip to content

Disable MCAD by default #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

anishasthana
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from astefanutti and Maxusmusti April 4, 2024 20:11
@dgrove-oss
Copy link
Collaborator

You probably know this, but #491 also accomplishes this. You'll have the same SDK e2e testing issues with this PR that are blocking #491 (and will need to make similar adjustments in the PR to the e2e tests for this repository to get them to work without AppWrappers).

Signed-off-by: Anish Asthana <[email protected]>
@anishasthana anishasthana force-pushed the add_mcad_config_flag branch from ef6960d to 102863d Compare April 4, 2024 21:50
Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from anishasthana. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anishasthana
Copy link
Contributor Author

Heya @dgrove-oss, yep! Just from a risk reduction perspective we need to keep minimal code changes due to some of the other large things that are in motion.

@jbusche
Copy link
Collaborator

jbusche commented Apr 5, 2024

Hi @anishasthana @tedhtchang I tried testing on my OC cluster - glad to re-test/try again tomorrow with extra instructions, but here's what I did so far.

  1. OC 4.14.17 with kustomize, podman, etc.
  2. Installed ODH 2.10.0 (It won't take startingCSV: opendatahub-operator.v2.4.0 anymore which is annoying)
  3. Now I need dsci manually - I applied one, then dsc with CodeFlare Component Removed.
  • I'm having trouble with model-mesh and kserve... I tried a few things but throwing up my hands for now on that.
  1. So, ok let's see if I can build the image and install it
    4.1 clone this PR
    git clone --single-branch --branch add_mcad_config_flag https://github.com/anishasthana/codeflare-operator.git
    cd codeflare-operator
    4.2 See if I can install or build an image
    make install
    make deploy
    make image-build
    4.3 tag and push to quay
    podman tag quay.io/project-codeflare/codeflare-operator:v0.0.0-anish quay.io/jbusche/codeflare-operator:pr499-anish
    podman push quay.io/jbusche/codeflare-operator:pr499-anish
    4.4 oc edit deploy codeflare-operator-manager -n openshift-operators
    image: quay.io/jbusche/codeflare-operator:pr499-anish
    4.5 check that it's running
oc get pods -n openshift-operators |grep codeflare
codeflare-operator-manager-fdc56c47b-q947k                 1/1     Running   0              14m

I'm leaving it where it is for now... not sure how to resolve the dsc issues or how to make sure KFTO/kueue are up if there's no MCAD.

@astefanutti
Copy link
Contributor

Superseded by #500.

@astefanutti astefanutti closed this Apr 5, 2024
@anishasthana anishasthana deleted the add_mcad_config_flag branch April 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants