-
Notifications
You must be signed in to change notification settings - Fork 59
add: raycluster oauth mutating webhook #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Path: "/spec/headGroupSpec/template/spec/containers/-", | ||
Value: newOAuthSidecar, | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tlsSecretVolume := corev1.Volume{ | |
Name: "proxy-tls-secret", | |
VolumeSource: corev1.VolumeSource{ | |
Secret: &corev1.SecretVolumeSource{ | |
SecretName: rayclusterName + "-proxy-tls-secret", | |
}, | |
}, | |
} | |
// Patch to add new volume | |
patches = append(patches, patchOperation{ | |
Op: "add", | |
Path: "/spec/headGroupSpec/template/spec/volumes/-", | |
Value: tlsSecretVolume, | |
}) |
Missing the tls-secret volume for the Volume Mount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great spot, thanks @Bobbins228
cdd51b3
to
5cb51fc
Compare
Issue link
https://issues.redhat.com/browse/RHOAIENG-1991
What changes have been made
Add Mutating Webhook to add OAuth SideCar to RayCluster
Verification steps
Setup environment.
Run the Codeflare-Operator from main
Build and deploy raycluster_webhook.
-kubectl apply -f deployment.yaml
Ensure the webhook is running in default namespace (will be changing this)
From the sdk, create a raycluster
Checks