Upgrade to go 1.21 #541
Merged
Upgrade to go 1.21 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/hold Making sure everything is setup downstream. |
jiripetrlik
approved these changes
Apr 23, 2024
|
rebased to resolve conflict in Dockerfile |
|
rebased yet again. |
|
/unhold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: astefanutti, jiripetrlik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 2cb14bb
into
project-codeflare:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out the upgrade to Go 1.21 (required by Kueue and AppWrapper) from #491 into a standalone PR. Hopefully this makes it easier to handle the downstream build system changes needed for the go update without the additional complexity of simultaneously adding the AppWrapper CRD and controller.
Obviously, this PR should be held until the downstream repos are ready to make the needed changes, but should be merged before we start working on the remaining pieces of #491.