Make sure that negative unit tests use own fork of RayCluster CR #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sutaakar
requested review from
ChristianZaccaria
and removed request for
Bobbins228 and
jbusche
ChristianZaccaria
approved these changes
Jul 26, 2024
| @@ -535,17 +536,15 @@ func TestValidateUpdate(t *testing.T) { | |||
| test.Expect(err).ShouldNot(HaveOccurred(), "Expected no errors on call to ValidateUpdate function") | |||
| }) | |||
|
|
|||
| // Negative Test Cases | |||
| trueBool := true | |||
There was a problem hiding this comment.
:) no comments
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/approved |
openshift-merge-bot
bot
merged commit 2cd228e
into
project-codeflare:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
What changes have been made
Creating own copy of RayCluster CR for every negative unit test to make sure they don't affect each other.
Verification steps
Run unit tests.
Checks