Skip to content

codeflare-operator manifests kustomize v5 upgrade #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

oksanabaza
Copy link
Contributor

@oksanabaza oksanabaza commented Aug 20, 2024

Issue link

RHOAIENG-6721

What changes have been made

Migration from kustomize v4 to kustomize v5

Verification steps

  1. Install kustomize v5 locally
  2. Run the kustomize build command on the original manifests to produce the current state of the resources kustomize build . > ${filename-v4}.yaml
  3. Update all other manifests to kustomize v5 labels
  4. Run the kustomize build command again on the updated manifests kustomize build . > ${filename-v5}.yaml
  5. Compare the output of the kustomize build command from both the original and updated manifests. diff ${filename-v4}.yaml ${filename-v5}.yaml
  6. Verify that there are no difference between outputs and no warning after kustomize build command

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@oksanabaza oksanabaza force-pushed the kustomize branch 4 times, most recently from 7139c5d to ee7e9b2 Compare August 21, 2024 12:34
@oksanabaza oksanabaza marked this pull request as ready for review August 21, 2024 12:44
@openshift-ci openshift-ci bot requested review from Bobbins228 and jbusche August 21, 2024 12:44
@astefanutti
Copy link
Contributor

@oksanabaza there is one pre-commit check that fails (EOF), once it's fixed it should be good to go.

Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Tested and works as expected nice work Oksana.

Copy link

openshift-ci bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, Bobbins228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ccf0f24 into project-codeflare:main Aug 27, 2024
8 checks passed
@oksanabaza oksanabaza changed the title codflare-operator manifests kustomize v5 upgrade codeflare-operator manifests kustomize v5 upgrade Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants