Get cluster #189
Merged
Get cluster #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPostOffice
reviewed
Jul 3, 2023
| try: | ||
| config.load_kube_config() | ||
| api_instance = client.CustomObjectsApi() | ||
| rcs = api_instance.list_namespaced_custom_object( |
There was a problem hiding this comment.
There was a problem hiding this comment.
@KPostOffice I get urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='localhost', port=80): Max retries exceeded with url: /apis/ray.io/v1alpha1/namespaces/default/rayclusters/quicktest when calling the get_namespaced_custom_object so I think there is something wrong with this function
| local_interactive=local_interactive, | ||
| ) | ||
| return Cluster(cluster_config) | ||
| raise FileNotFoundError( |
There was a problem hiding this comment.
If you are able to use the function suggested above then the error handling can be removed here.
|
I tried it out on my OC 4.12 cluster and it's looked good - but Carson noticed a min/max workers aren't matching what was defined: But the cluster.config is reporting just 1 each: |
jbusche
approved these changes
Jul 6, 2023
Maxusmusti
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Add: get_cluster function to get cluster with specified name and namespace * Test: make unit tests for get_cluster function
Maxusmusti
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Add: get_cluster function to get cluster with specified name and namespace * Test: make unit tests for get_cluster function
Maxusmusti
added a commit
that referenced
this pull request
Jul 20, 2023
* First pass on just the basics * Added namespace retrieval and dashboard route access via kubernetes * Added exception handling * Remove unnecessary comment * Change AW fs loading to k8s and begin converting unit tests * Finished unit test update * Update requirements * Get cluster (#189) * Add: get_cluster function to get cluster with specified name and namespace * Test: make unit tests for get_cluster function * Fix: unit test failing because of ray cluster obj changed (#208) * Remove oc client and add helper functions (#187) * Remove oc client and add helper functions * Updates for error checking * make sure tests run without oc login * Removing CLI appwrapper generation * Updated import --------- Co-authored-by: Mustafa Eyceoz <[email protected]> * Remove unused import * Update authentication for K8s (#237) * Updated authentication for Kubernetes * Updated template name and comment * Updated login functionality * Altered config_check() function * Altered comments and changed config_check() function * Added logic for handling current namespace when a user authenticates via kube client * Changed formatting * Made handler functions generic and altered get_current_namespace() functionality * Changed error message for cluster configuration * Removed default values for token + server * Added check for correct credentials * Changed how using certs works with certifi.where * Added unit tests for new authentication methods * Fixed formatting and updated .gitignore to include test created files * Fixed .gitignore * Updated unit authentication tests --------- Co-authored-by: Carson Harrell <[email protected]> Co-authored-by: ted chang <[email protected]> Co-authored-by: Mark Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature #183
Makes function that returns Cluster object based on the cluster name and namespace
Tested using unit tests