Skip to content

Fix: unit test failing because of ray cluster obj changed #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix: unit test failing because of ray cluster obj changed #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/unit_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,10 +794,10 @@ def get_ray_obj(group, version, namespace, plural, cls=None):
"workerGroupSpecs": [
{
"groupName": "small-group-quicktest",
"maxReplicas": 2,
"minReplicas": 2,
"maxReplicas": 1,
"minReplicas": 1,
"rayStartParams": {"block": "true", "num-gpus": "0"},
"replicas": 2,
"replicas": 1,
"template": {
"metadata": {
"annotations": {"key": "value"},
Expand Down Expand Up @@ -1553,7 +1553,7 @@ def test_get_cluster(mocker):
cluster_config.image
== "ghcr.io/foundation-model-stack/base:ray2.1.0-py38-gpu-pytorch1.12.0cu116-20221213-193103"
)
assert cluster_config.min_worker == 2 and cluster_config.max_worker == 2
assert cluster_config.min_worker == 1 and cluster_config.max_worker == 1


def test_list_clusters(mocker, capsys):
Expand Down