make namespace configurable #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/do not merge After some testing, it looks like this will deploy the AW into the correct namespace, but attempts to deploy the ray pods into the "default" namespace. Needs more testing, before merging. |
MichaelClifford
force-pushed
the
handleNamespaces
branch
from
18d125f to
10804fc
Compare
|
Most Recent update should be good :) |
MichaelClifford
force-pushed
the
handleNamespaces
branch
2 times, most recently
from
be48c21 to
4e30a64
Compare
|
OK, this has been tested and rebased on top the most recent commits and includes changes to configure the dashboard route to the correct namespace as well. |
MichaelClifford
force-pushed
the
handleNamespaces
branch
from
4e30a64 to
17e36aa
Compare
Maxusmusti
approved these changes
Nov 17, 2022
Maxusmusti
requested changes
Nov 17, 2022
MichaelClifford
force-pushed
the
handleNamespaces
branch
from
17e36aa to
927fadb
Compare
|
thanks @Maxusmusti, changed! |
Maxusmusti
requested changes
Nov 21, 2022
MichaelClifford
force-pushed
the
handleNamespaces
branch
from
927fadb to
e7a1745
Compare
Maxusmusti
requested changes
Nov 21, 2022
| env = {} | ||
|
|
||
| outfile = generate_appwrapper(name, min_cpu, max_cpu, min_memory, max_memory, gpu, workers, template, image, instascale, instance_types, env) | ||
| outfile = generate_appwrapper(name, min_cpu, max_cpu, min_memory, max_memory, gpu, workers, template, image, instascale, instance_types, namespace, env) |
There was a problem hiding this comment.
In the generate_appwrapper def, you have namespace as the second argument, so it probably needs to be the second argument in this call as well
MichaelClifford
force-pushed
the
handleNamespaces
branch
from
e7a1745 to
88b0efd
Compare
Maxusmusti
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the SDK so that the namespace is more easily configurable. However, it still defaults to the "default" namespace. Also added a function
get_current_namespacethat will return the name of the the namespace you are currently working in.