Cli submit delete raycluster #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and change test slightly
Fiona-Waters
reviewed
Aug 1, 2023
|
/lgtm |
carsonmh
added a commit
that referenced
this pull request
Aug 11, 2023
* add: create cluster from yaml function * add: submit and delete functions * change: cluster_name to name in submit raycluster * add: load_auth in delete function * update: make get_cluster function use new config * test: unit tests for submit and delete raycluster commands * change: format slightly on submit/delete commands * Add: context for current namespace and .codeflare path * fix: remove load_auth in functions so it doesn't run twice * Add: help messages for submit and delete functions * cleanup * remove: remove get_namespace every function call * fix: fix tests * change: make namespace default to 'default' and change test slightly * refactor: remove unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Closes #239
What changes have been made
submit rayclusteranddelete rayclusterto the CLI so the user can submit and delete to and from their Kubernetes cluster from the terminal. Unit tests included..codeflarefolder are loaded and saved for each command to access.Cluster.from_definition_yamlcommand to get aClusterobject from a defined yaml file.Verification steps
After building SDK, you can run
codeflareto see a list of all commands.codeflare define rayclusterand then you can submit it usingcodeflare submit rayclusterspecifying namecodeflare delete rayclusterspecifying name and namespace.You can also run the unit tests with
python -m pytest tests/unit_test.pyorpytest -v tests/unit_test.py.Checks