Remove creation of OAuth resources/logic and remove openshift_oauth option

[ChristianZaccaria]

Issue link

Issue: https://issues.redhat.com/browse/RHOAIENG-1993

What changes have been made

• This PR removes the logic in the SDK that creates the OAuth resources.
• Remove openshift_oauth from ClusterConfiguration as defaulting to True.
• Added COOKIE_SECRET env for oauth proxy container. - Here
• Removed unit tests related to the creation/deletion of OAuth resources.
• Adjusted test cases and unit tests.
• Verified this change works with the RayCluster Controller
• Add verify_tls option to ClusterConfiguration: this option is set to True by default but still has the option to change for debugging. Based on this option the endpoint will be verified, if set to false, it alters if the user verifies that the certificate is trusted.

Verification steps

To test these changes:
0. In an OpenShift cluster.

1. Checkout this PR RayCluster Controller. In the CFO repository you can run the CFO in your cluster with make run NAMESPACE=default and make install.
2. Deploy and install KubeRay
3. Checkout this PR and install the SDK
4. Run through this notebook, change between verify_tls=True/False.
5. Once cluster.up() is ran, the oauth-proxy sidecar is created by default if on an OpenShift cluster. You should find several resources created including a ServiceAccount named jobtest-oauth-proxy and a route named ray-dashboard-jobtest which were created by the RayCluster Controller as opposed by the SDK.
6. The route should be accessible through authentication.

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[KPostOffice]

Looks good, one comment

[Srihari1192]

@ChristianZaccaria
Ray Dashboard route is accessible successfully now, but noticed below error during ray cluster creation in Controller logs

2024-03-21T15:57:08+05:30       ERROR   Failed to update RayCluster with finalizer      {"controller": "codeflare-raycluster-controller", "controllerGroup": "ray.io", "controllerKind": "RayCluster", "RayCluster": {"name":"jobtest-1","namespace":"default"}, "namespace": "default", "name": "jobtest-1", "reconcileID": "8f0aa895-6eb3-40d7-9704-b5b9a232c76a", "requeueing": "true", "error": "Operation cannot be fulfilled on rayclusters.ray.io \"jobtest-1\": the object has been modified; please apply your changes to the latest version and try again"}
github.com/project-codeflare/codeflare-operator/controllers.(*RayClusterReconciler).Reconcile
       /Users/hari/Development/codeflare-operator/controllers/raycluster_controller.go:109
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:118
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:314
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:265
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:226
2024-03-21T15:57:08+05:30       ERROR   Reconciler error        {"controller": "codeflare-raycluster-controller", "controllerGroup": "ray.io", "controllerKind": "RayCluster", "RayCluster": {"name":"jobtest-1","namespace":"default"}, "namespace": "default", "name": "jobtest-1", "reconcileID": "8f0aa895-6eb3-40d7-9704-b5b9a232c76a", "error": "Operation cannot be fulfilled on rayclusters.ray.io \"jobtest-1\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:324
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:265
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2```

[Bobbins228]

Hi @Srihari1192,
That issue seems to be related to the Ray Cluster Controller more so than the SDK changes made here

[ChristianZaccaria]

@ChristianZaccaria Ray Dashboard route is accessible successfully now, but noticed below error during ray cluster creation in Controller logs

2024-03-21T15:57:08+05:30       ERROR   Failed to update RayCluster with finalizer      {"controller": "codeflare-raycluster-controller", "controllerGroup": "ray.io", "controllerKind": "RayCluster", "RayCluster": {"name":"jobtest-1","namespace":"default"}, "namespace": "default", "name": "jobtest-1", "reconcileID": "8f0aa895-6eb3-40d7-9704-b5b9a232c76a", "requeueing": "true", "error": "Operation cannot be fulfilled on rayclusters.ray.io \"jobtest-1\": the object has been modified; please apply your changes to the latest version and try again"}
github.com/project-codeflare/codeflare-operator/controllers.(*RayClusterReconciler).Reconcile
       /Users/hari/Development/codeflare-operator/controllers/raycluster_controller.go:109
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:118
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:314
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:265
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:226
2024-03-21T15:57:08+05:30       ERROR   Reconciler error        {"controller": "codeflare-raycluster-controller", "controllerGroup": "ray.io", "controllerKind": "RayCluster", "RayCluster": {"name":"jobtest-1","namespace":"default"}, "namespace": "default", "name": "jobtest-1", "reconcileID": "8f0aa895-6eb3-40d7-9704-b5b9a232c76a", "error": "Operation cannot be fulfilled on rayclusters.ray.io \"jobtest-1\": the object has been modified; please apply your changes to the latest version and try again"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:324
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
       /Users/hari/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:265
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2```

cc: @KPostOffice

[KPostOffice]

/lgtm

[KPostOffice]

/hold

[ChristianZaccaria]

Note: I performed a rebased

[Bobbins228]

This needs a pre-commit run --all-files run on the repo

[Bobbins228]

/approve

[Bobbins228]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Bobbins228,KPostOffice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment