-
Notifications
You must be signed in to change notification settings - Fork 51
Altered demo notebooks for Kueue default & mTLS default #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Altered demo notebooks for Kueue default & mTLS default #486
Conversation
1b3d273
to
0ce4a79
Compare
7e1b6ab
to
1aac7da
Compare
Updated existing notebooks in favour of Kueue specific nb Updated wording
845484e
to
7d47f0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently setting up to run some of the notebooks on openshift. Just some comments first. Thanks @Bobbins228
demo-notebooks/guided-demos/notebook-ex-outputs/2_cluster_job_client.ipynb
Outdated
Show resolved
Hide resolved
Just wondering why we are not adding |
This is because by default we do not write to a file but I could include it with a comment if that sounds like it would be beneficial to new users |
demo-notebooks/guided-demos/notebook-ex-outputs/1_cluster_job_client.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested some of the notebooks on openshift and they work as expected. Just one small comment but otherwise looks great to me. Great work Mark!
Co-authored-by: Fiona Waters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested some notebooks and it worked as expected
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChughShilpa, Fiona-Waters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
87e6f26
into
project-codeflare:main
Issue link
RHOAIENG-1913
What changes have been made
Updated existing notebooks to use Kueue by default and have notes for setup.
Removed mention of local_interactive
Removed InstaScale NB and mentions of MCAD from other NBs
Verification steps
Run the demo notebook when #470
Checks