Skip to content

raise error if raycluster crd not available #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2024
Merged

raise error if raycluster crd not available #493

merged 3 commits into from
Apr 26, 2024

Conversation

KPostOffice
Copy link
Collaborator

@KPostOffice KPostOffice commented Mar 29, 2024 •
edited
Loading

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from anishasthana and dimakis March 29, 2024 21:55
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kpostoffice. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KPostOffice KPostOffice force-pushed the rhoaeng-2285 branch 7 times, most recently from a64bf9d to df2d528 Compare April 1, 2024 20:42
Bobbins228
Bobbins228 reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great idea works as expected 👍
should this be included in the cluster.down() method as well.

@KPostOffice
Copy link
Collaborator Author

cluster.down()

Yeah, I'll add it there as well

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2024
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 16, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
@KPostOffice KPostOffice merged commit 82d2c5b into project-codeflare:main Apr 26, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobbins228 Bobbins228 Bobbins228 left review comments

@anishasthana anishasthana Awaiting requested review from anishasthana

@dimakis dimakis Awaiting requested review from dimakis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KPostOffice @Bobbins228 @openshift-merge-robot