Remove ingress/routes logic from SDK #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
ChristianZaccaria
force-pushed
the
remove-logic
branch
2 times, most recently
from
b9111dc to
d536acb
Compare
ChristianZaccaria
force-pushed
the
remove-logic
branch
from
d536acb to
0cddf34
Compare
4 tasks
ChristianZaccaria
force-pushed
the
remove-logic
branch
2 times, most recently
from
c461fc1 to
d5559f9
Compare
ChristianZaccaria
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold to be merged with project-codeflare/codeflare-operator#493 |
openshift-ci
bot
added
the
do-not-merge/hold
ChristianZaccaria
force-pushed
the
remove-logic
branch
3 times, most recently
from
b27cad1 to
6120d21
Compare
Bobbins228
reviewed
Apr 5, 2024
ChristianZaccaria
force-pushed
the
remove-logic
branch
from
6120d21 to
18da98a
Compare
Bobbins228
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Issue: https://issues.redhat.com/browse/RHOAIENG-1056
What changes have been made
ingress_optionsfromClusterConfigurationand adjusted e2e tests accordingly.base-template.yamland adjusted unit-tests accordingly.Add is_kind_cluster()ingress_domainparameterVerification steps
To be tested with: project-codeflare/codeflare-operator#493
The e2e tests here will not pass until the above PR is merged as the workflow builds the CodeFlare Operator from main branch.
Checks