-
Notifications
You must be signed in to change notification settings - Fork 51
ClusterConfiguration parameter that will accept user inputted labels and apply them to the Ray Cluster on creation. #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b18fea0
to
3f10782
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes tested and works as expected:
- Labels added to the generated RayCluster YAML.
- On creation, RayCluster CR contains the supplied labels.
/lgtm - needs rebase |
Rebased |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran a demo notebook on openshift and it works as expected with the labels being added to the generated yaml and the resulting raycluster instance.
Just a couple of nitpicks but otherwise good to go. Thanks Ignas!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria, Fiona-Waters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9b49b59
into
project-codeflare:main
Issue link
RHOAIENG-2017
What changes have been made
Add a ClusterConfiguration parameter that will accept user inputted labels and apply them to the Ray Cluster on creation.
Verification steps
Defining the ClusterConfiguration with 3 labels would generate the RayCluster with those labels + any other ones that are already part of it.
Checks