Skip to content

Adding validation for local_queue provided in cluster config #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Fiona-Waters
Copy link
Contributor

@Fiona-Waters Fiona-Waters commented May 10, 2024

Issue link

RHOAIENG-7064

What changes have been made

Currently when specifying local_queue, if any value is provided the ray cluster can be created. Added a check to validate local_queue name provided by user in cluster configuration exists.

Verification steps

  • Install RHOAI with codeflare components set to Managed
  • In a jupyter notebook install codeflare sdk from this branch
git clone https://github.com/Fiona-Waters/codeflare-sdk.git -b local-queue
cd codeflare-sdk
pip install poetry
poetry install
  • Restart the kernal and run through a demo notebook
    • Ensure that you do not have the required annotation for the default local queue set.
  • scenario 1
    • Set the local_queue parameter to foobar and check that you cannot continue and you see the correct error message.
  • scenario 2
    • Provide an existing local_queue name and see that you can continue and create the ray cluster
  • scenario 3
    • Comment out the local_queue parameter and see that you get the correct error message.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from Bobbins228 and dimakis May 10, 2024 11:19
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: franciscojavierarceo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [franciscojavierarceo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@Fiona-Waters Fiona-Waters requested a review from KPostOffice May 20, 2024 11:17
@KPostOffice
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 32cb751 into project-codeflare:main May 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants