Skip to content

e2e tests: Setup Go version based on CFO go.mod file #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2024

Conversation

sutaakar
Copy link
Contributor

Issue link

What changes have been made

CodeFlare operator was upgraded to Go 1.21, breaking current e2e PR check.
This PR patches e2e workflow to setup Go version based on CodeFlare operator go.mod file.

Verification steps

PR check should pass.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@sutaakar sutaakar requested a review from jiripetrlik May 20, 2024 08:46
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@Fiona-Waters
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fiona-Waters, jiripetrlik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 890975e into project-codeflare:main May 20, 2024
4 checks passed
@sutaakar sutaakar deleted the e2e-go branch May 20, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants