Use native gRPC resolver in PR check for local interactive #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolver is compatible with dnsmasq used for dynamic hostnames in KinD.
astefanutti
reviewed
May 21, 2024
|
/lgtm |
jiripetrlik
approved these changes
May 21, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fiona-Waters, jiripetrlik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit b782a4a
into
project-codeflare:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolver is compatible with dnsmasq used for dynamic hostnames in KinD.
Issue link
https://issues.redhat.com/browse/RHOAIENG-7055
What changes have been made
Use native gRPC resolver which is compatible with dnsmasq.
Use Python 3.9 which is compatible with latest Ray image in CodeFlare repo.
Verification steps
Should be verified together with changes in #532
Checks