SA get current namespace

[KPostOffice]

Issue link

supersedes #539

What changes have been made

add check for SA namespace as default

Verification steps

use RHOAI workbook, clone this branch and run pip install . see that the namespace retrieved is the same as the project that you are in

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[astefanutti]

/lgtm

[ChristianZaccaria]

Will we want to enable the following test as part of this fix, or address in a separate PR?
https://github.com/project-codeflare/codeflare-sdk/blob/main/src/codeflare_sdk/cluster/cluster.py#L724

https://github.com/project-codeflare/codeflare-sdk/blob/main/tests/unit_test.py#L579

Apart from the above question, all works as expected!

[ChristianZaccaria]

Wondering if it's a good idea to set something like this to all notebooks, further removing the need for user input:

cluster = Cluster(ClusterConfiguration(
    name='raytest',
    namespace= cluster.get_current_namespace(),

I think we would need to add the import too for usage:
from codeflare_sdk.cluster import cluster

[KPostOffice]

Wondering if it's a good idea to set something like this to all notebooks, further removing the need for user input:

cluster = Cluster(ClusterConfiguration(
    name='raytest',
    namespace= cluster.get_current_namespace(),

I think we would need to add the import too for usage: from codeflare_sdk.cluster import cluster

If config doesn't have a namespace set it should use the current working namespace

[KPostOffice]

Will we want to enable the following test as part of this fix, or address in a separate PR? https://github.com/project-codeflare/codeflare-sdk/blob/main/src/codeflare_sdk/cluster/cluster.py#L724

https://github.com/project-codeflare/codeflare-sdk/blob/main/tests/unit_test.py#L579

Apart from the above question, all works as expected!

I'm not sure what the test is testing exactly. Can we leave it out for now?

[ChristianZaccaria]

/lgtm just needs a rebase, thank you!

[Fiona-Waters]

I ran a demo notebook without providing the namespace and the rhods-notebooks namespace was retrieved from /var/run/secrets/kubernetes.io/serviceaccount/namespace. Works as expected.
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fiona-Waters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Fiona-Waters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment