Fix for the odh-notebook-sync workflow. #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup of project-codeflare#655 where the Pipfile.cpu and Pipfile.gpu support was broken. Apart from that - the array initialization was fixed and the link to this workflow is added to the raised PR description.
openshift-ci
bot
requested review from
ChristianZaccaria and
MichaelClifford
KPostOffice
approved these changes
Sep 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit bdedaff
into
project-codeflare:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup of #655 where the Pipfile.cpu and Pipfile.gpu support was broken. Apart from that - the array initialization was fixed and the link to this workflow is added to the raised PR description.
The original problem with the missing
[(test) keyword can be seen in the execution also, see multiple errors here, eg:@KPostOffice FYI
Issue link
What changes have been made
Verification steps
I didn't tested it anyhow.
Checks