-
Notifications
You must be signed in to change notification settings - Fork 51
Add codecov for unit test coverage #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codecov for unit test coverage #693
Conversation
882327e
to
4e6b808
Compare
@ChristianZaccaria Could we merge this to check if coverage reports are being uploaded? Looks like it should automatically search for coverage files in the repo and add it - so no more path configuration is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for merge on my side
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought on this actually:
702dcb0
to
f8fca9b
Compare
/hold The action seems to be failing with rate limiting error mentioning that a new token is required. |
f8fca9b
to
3d32432
Compare
3d32432
to
01b52f5
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChristianZaccaria, KPostOffice, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0d445fe
into
project-codeflare:main
Issue link
What changes have been made
Verification steps
Checks