Skip to content

Enhance SDK documenation #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Bobbins228
Copy link
Contributor

@Bobbins228 Bobbins228 commented Oct 3, 2024

Issue link

Relates to: RHOAIENG-9511

What changes have been made

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Copy link
Contributor

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bobbins228. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobbins228 Bobbins228 force-pushed the enhance-documentation branch from ecdcc18 to c6d245b Compare October 4, 2024 15:00
@Bobbins228 Bobbins228 requested a review from Ygnas October 4, 2024 15:01
@Bobbins228 Bobbins228 force-pushed the enhance-documentation branch 2 times, most recently from 412e0ff to e827184 Compare October 4, 2024 15:40
@Bobbins228 Bobbins228 requested a review from Ygnas October 4, 2024 15:40
@Bobbins228 Bobbins228 force-pushed the enhance-documentation branch from e827184 to bba21de Compare October 9, 2024 08:28
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.99%. Comparing base (b90d5d6) to head (a480cd7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files          36       36           
  Lines        2364     2364           
=======================================
  Hits         2222     2222           
  Misses        142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…on for ray clusters and ui widgets

Signed-off-by: Bobbins228 <[email protected]>
@Bobbins228 Bobbins228 force-pushed the enhance-documentation branch from bba21de to a480cd7 Compare October 10, 2024 09:35
@Bobbins228 Bobbins228 mentioned this pull request Oct 15, 2024
4 tasks
@Bobbins228
Copy link
Contributor Author

Closing in favour of #709

@Bobbins228 Bobbins228 closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants