Skip to content

Intuit python version for compatible Ray image #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChristianZaccaria
Copy link
Collaborator

@ChristianZaccaria ChristianZaccaria commented Oct 16, 2024

Issue link

Jira: https://issues.redhat.com/browse/RHOAIENG-14578

What changes have been made

The Ray image to be used by the head and worker nodes will be based on the python version in the system.

Currently, we support py3.9, and we will now support Ray with py3.11.

Verification steps

  1. Launch a jupyter notebook server with python3.9.
  2. Run through the 0_basic_ray.ipynb notebook with the write_to_file parameter set to True.
  3. See the Ray image used in the head and worker group specs.
  4. Repeat but with python3.11.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@ChristianZaccaria
Copy link
Collaborator Author

/hold require the SHA for ray py3.11

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024

This comment was marked as outdated.

@ChristianZaccaria ChristianZaccaria force-pushed the dynamic-default-ray-image branch 2 times, most recently from c754f64 to 2495e74 Compare October 16, 2024 11:58
@ChristianZaccaria ChristianZaccaria force-pushed the dynamic-default-ray-image branch 2 times, most recently from d198ba5 to fc28686 Compare October 16, 2024 16:11
@ChristianZaccaria ChristianZaccaria force-pushed the dynamic-default-ray-image branch from 0ab047e to 58ab856 Compare October 17, 2024 12:47
@ChristianZaccaria ChristianZaccaria removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2024
@ChristianZaccaria ChristianZaccaria force-pushed the dynamic-default-ray-image branch from 58ab856 to f278546 Compare October 17, 2024 13:11
@ChristianZaccaria ChristianZaccaria force-pushed the dynamic-default-ray-image branch from f278546 to e9e88c2 Compare October 17, 2024 13:12
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on py3.9 & 3.11 and it works as expected!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2024
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Bobbins228,KPostOffice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 51d0b2f into project-codeflare:main Oct 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants