Add Snyk Security workflow to monitor multiple tags #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianZaccaria
requested review from
varshaprasad96
and removed request for
Maxusmusti
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 36 36
Lines 2403 2403
=======================================
Hits 2235 2235
Misses 168 168 ☔ View full report in Codecov by Sentry. |
ChristianZaccaria
force-pushed
the
snyk-multiple-branches
branch
from
11d4554 to
cfaf9b1
Compare
KPostOffice
reviewed
Nov 4, 2024
|
Looks good, just a couple of comments 👍🏻 |
ChristianZaccaria
changed the title
ChristianZaccaria
force-pushed
the
snyk-multiple-branches
branch
from
5a0b35d to
b38f673
Compare
|
Enhancements based off this comment have been added: |
ChristianZaccaria
force-pushed
the
snyk-multiple-branches
branch
from
b38f673 to
6c486b7
Compare
openshift-ci
bot
added
lgtm
Ygnas
approved these changes
Nov 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KPostOffice, Ygnas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9af07a0
into
project-codeflare:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
Jira: https://issues.redhat.com/browse/RHOAIENG-14391
What changes have been made
codeflare-sdktags that we continue to support in RHOAI. Snyk is now monitoring them here: [Snyk Dashboard]. For reference, the workflow used to generate this initial import/monitoring was ran here: [initial workflow run].The above list was created based off the list of RHOAI supported versions compared to the tags in the ImageStream annotations in the notebooks repository.
I've added the Snyk
secretsfor authentication.1- Created "Snyk Security" workflow that will trigger on push events to
mainbranch.This workflow will authenticate with Snyk from our org. Then, it will monitor the
codeflare-sdkdependencies frommainbranch.Verification steps
Workflow run in my fork: https://github.com/ChristianZaccaria/codeflare-sdk/actions/runs/11610603721/job/32330214880
Example result:
Snyk - CodeFlare-SDK
Maintainability
In terms of new release tags the release workflow will add all subsequent new release tags to Snyk UI, this way monitoring all newest tags.
In terms of older tags, RHOAI releases and their support period are listed [here]. Sometimes, the support can be extended for some of the versions. It's best to manually remove unsupported tags from time to time. There's no harm in monitoring multiple tags.
Checks