-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(RHOAIENG-20531): propagate annotations to ray pods #809
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 23 23
Lines 1396 1396
=======================================
Hits 1290 1290
Misses 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0b5fc41
to
217522c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks clean but the annotations config vars are added to tests that are not really necessary/are helper functions.
The create_cluster_all_config_params()
test is a fine place to put them for testing purposes but you need to assert that the params are set properly in the test_config_creation_all_parameters Unit Test.
206fe10
to
901de36
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
901de36
to
6529505
Compare
Signed-off-by: Pat O'Connor <[email protected]>
6529505
to
f0f722b
Compare
Issue link
RHOAIENG-20531
What changes have been made
Fix to propagate annotations passed in the cluster config to the Ray head and worker pods.
Verification steps
Checks