Skip to content

remote ray client example #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laurafitzgerald
Copy link

No description provided.

@openshift-ci openshift-ci bot requested review from Bobbins228 and Fiona-Waters May 29, 2025 14:17
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.45%. Comparing base (028d0d5) to head (7a38136).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #833   +/-   ##
=======================================
  Coverage   92.45%   92.45%           
=======================================
  Files          24       24           
  Lines        1419     1419           
=======================================
  Hits         1312     1312           
  Misses        107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@kryanbeane kryanbeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than comment about token formatting, lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 29, 2025
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the language to Python instead of plain text?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@laurafitzgerald laurafitzgerald force-pushed the remote-client-example branch from dcbe579 to a89a19e Compare May 29, 2025 14:28
Co-authored-by: bkeane <[email protected]>
Co-authored-by: chipspeak <[email protected]>
Co-authored-by: Bobbins <[email protected]>
@laurafitzgerald laurafitzgerald force-pushed the remote-client-example branch from a89a19e to 7a38136 Compare May 29, 2025 14:31
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kryanbeane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

"# Setup Authentication Configuration \n",
"\n",
"header = {\n",
" 'Authorization': f'Bearer {\"<auth-token>\"}'\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this would be clearer:

auth_token = "XXXX" # Your OpenShift authentication token

header = {
    'Authorization': f'Bearer {auth_token}'
}

"metadata": {},
"outputs": [],
"source": [
"# Submit an a job using the RayJobClient\n",
Copy link
Contributor

@chipspeak chipspeak May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Submit a job using the RayJobClient

"# Import pieces from codeflare-sdk\n",
"from codeflare_sdk import Cluster, ClusterConfiguration, TokenAuthentication, RayJobClient\n",
"\n",
"# Gather the dashboard URL\n",
Copy link
Contributor

@chipspeak chipspeak May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of clarity might we say:

# Gather the dashboard URL (provided by the RayCluster creator)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants