Skip to content

E2E test with Pod generic resource and MinAvailable > 1 fail #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astefanutti opened this issue Jul 7, 2023 · 2 comments
Closed

E2E test with Pod generic resource and MinAvailable > 1 fail #463

astefanutti opened this issue Jul 7, 2023 · 2 comments
Labels
bug Something isn't working testing Items related to testing

Comments

@astefanutti
Copy link
Contributor

In #457, the e2e tests using the removed .Items field have been migrated to using the .GenericItems field.

That has surfaced an issue for the test that covers the creation of an AppWrapper with a Pod generic resource, and uses .spec.schedulingSpec.minAvailable = 2, described as:

Create AppWrapper - PodTemplate Only - 2 Pods

The other tests, with Pod as generic resource, also fail when .spec.schedulingSpec.minAvailable > 1.

It may be an issue in the way Pod generic resource are handled.

@asm582
Copy link
Member

asm582 commented Jul 7, 2023

@astefanutti Thanks for creating the issue, I am trying to understand this issue better. changes to move to GenericItems should not be impacting schedulingSpec field. can you please describe a bit more about the issue that you are facing please?

@astefanutti
Copy link
Contributor Author

Let me close this as this is not an issue anymore with #457 rebased on top of the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Items related to testing
Projects
Development

No branches or pull requests

2 participants