Remove non-generic resource items from AppWrapper API #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm582
reviewed
Jul 6, 2023
|
Thanks for this PR, pod controller is being used in MCAD, we need to add that back. Also, a couple of test cases are failing worth investigating the reason for failure. |
astefanutti
changed the title
|
I've created #463 as a follow up. |
z103cb
previously approved these changes
Jul 14, 2023
|
@astefanutti Thanks for this PR, we merge a few PRs in MCAD that have made fundamental changes to the controller, can you please resolve conflicts and run the build? |
|
@asm582 conflicts are now resolved, PTAL. |
z103cb
approved these changes
Jul 24, 2023
This was referenced Jul 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #428.
Fixes #264.