Skip to content

api: Generate CRDs from APIs #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2023
Merged

api: Generate CRDs from APIs #456

merged 6 commits into from
Jul 25, 2023

Conversation

astefanutti
Copy link
Contributor

@astefanutti astefanutti commented Jul 6, 2023

Breaks #452 into multiple PRs.

Closes #294.

@astefanutti astefanutti requested review from z103cb and asm582 July 25, 2023 13:18
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would wait for @asm582 and @metalcycling to chime in before merging.

Copy link
Member

@asm582 asm582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the question, LGTM

@asm582 asm582 merged commit a1984c7 into project-codeflare:main Jul 25, 2023
@astefanutti astefanutti deleted the pr-crd branch July 25, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernize CRD change process
3 participants