update only running AWs

[asm582]

Issue link

#561

What changes have been made

Verification steps

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • Testing is not required for this change

[asm582]

all test cases pass locally
refact_uqj.log

[metalcycling]

I'm confused about what we are trying to do here. Some things I notice:

• In line 1467 we check if the newjob exists in the eventQueue, if it does then we continue. If it doesn't exist, then we will eventually get to line 1476 and delete it from the eventQueue, even though it doesn't exists there.
• Line 1478 adds newjob back in the event queue

So ok. If the job exists in the event queue or job queue then nothing happens, if it doesn't then it deletes it (maybe) and adds it to the event queue. I'm not sure what this is supposed to accomplish. In the previous version there were some changes to the newjob object, but this one doesn't. I just want to make sure I understand the logic of this function.

[asm582]

I'm confused about what we are trying to do here. Some things I notice:

• In line 1467 we check if the newjob exists in the eventQueue, if it does then we continue. If it doesn't exist, then we will eventually get to line 1476 and delete it from the eventQueue, even though it doesn't exists there.
• Line 1478 adds newjob back in the event queue

So ok. If the job exists in the event queue or job queue then nothing happens, if it doesn't then it deletes it (maybe) and adds it to the event queue. I'm not sure what this is supposed to accomplish. In the previous version there were some changes to the newjob object, but this one doesn't. I just want to make sure I understand the logic of this function.

Thanks for the review @metalcycling , Multiple threads compete to add objects to the event queue, we want to make sure updatequeuejob thread adds the latest object from etcd into the event queue, I agree this is a best-effort solution.

[z103cb]

There's a small nitpick with a log message that needs to be addressed and that prevents me from approving this PR.

I think changes from this PR are long overdue.

If this the nitpick is addressed and there are no other objections I will approve this on Monday.

/LGTM

[metalcycling]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalcycling

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [metalcycling]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment