Skip to content

Enhance MCAD Logs and fix naming consistency #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChristianZaccaria
Copy link
Contributor

Issue link

Resolves #644

Motivation

In the scenario where we want to create an AW in two different namespaces but with the same name, it is important to know which AppWrapper the logs are referring to.

Previously:

  • There are a number of instances where the logs only provide the name of the AppWrapper or Job, instead of following the most used pattern of namespace/name as done i.e., here.

  • There are a couple of places where the logs display name/name, such as here.

  • A few places have the name/namespace pattern, which can be inconsistent when looking/searching through the logs.

  • Few instances where i.e., qj.Name is provided in the Info log but not used.

What changes have been made

  • The logs now consistently refer to the AppWrappers or Jobs in the form of namespace/name.
  • Typo fixes.

Verification steps

  • With MCAD running, create an AppWrapper, and check MCAD logs for <namespace/name> of your AW.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests

@astefanutti
Copy link
Contributor

/lgtm

@astefanutti
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7f3eda5 into project-codeflare:main Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Logging Details
3 participants