Vendor libprojectM in projectm-sys crate #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't say much about best practices for building Rust crates, but I guess it's good as-is. Alternatively, instead of a submodule, the create could also download the latest release ZIP/TGZ from GitHub. But that would most probably make it harder to build crates from dev branches of libprojectM, so the submodule is fine. |
kblaschke
approved these changes
Sep 11, 2024
Blaquewithaq
approved these changes
Oct 23, 2024
|
Something is going on with the tests now tho. |
revmischa
changed the title
|
I fixed up the build and packaging. Tests are green, new versions of the modules are published. Seems chill now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to libprojectM v4.1.0
Use submodules to get the source