Skip to content

Upgrade LLVM JIT #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Upgrade LLVM JIT #360

wants to merge 2 commits into from

Conversation

revmischa
Copy link
Collaborator

For new LLVM version (9+)
Doesn't quite work. Need help.

@revmischa revmischa requested a review from mbellew May 26, 2020 13:13
@labkey-matthewb
Copy link
Contributor

Hi Mischa, I made a similar change a few weeks ago when I upgrade a machine to Ubuntu 20.04. In addition to these few changes, I had to change the build to use c++14. That is why I didn't immediately create a PR, because I don't really know the implications of that.

See this commit on branch llvm_10:

58e0a51

@revmischa
Copy link
Collaborator Author

When I ran it with my changes I get bad access crash when it initializes the engine
ExecutionEngine* executionEngine = EngineBuilder(std::move(jitx.module_ptr)).create();

@labkey-matthewb
Copy link
Contributor

When I ran it with my changes I get bad access crash when it initializes the engine
ExecutionEngine* executionEngine = EngineBuilder(std::move(jitx.module_ptr)).create();

Maybe some subtle difference between llvm::make_unique/move and std::make_unique/move? (I haven't looked inside the implementation)

@revmischa
Copy link
Collaborator Author

Done in #470 and kblaschke@0dc7efe

@revmischa revmischa closed this Jul 4, 2021
@revmischa revmischa deleted the llvm-upgrade branch March 6, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants