v4.1.x - Add PThreads option for Emscripten #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaquewithaq
changed the title
dpw13
reviewed
Mar 6, 2024
CMakeLists.txt
Outdated
| @@ -60,6 +60,7 @@ file(TOUCH "${PROJECTM_DUMMY_SOURCE_FILE}") | |||
|
|
|||
| if(CMAKE_SYSTEM_NAME STREQUAL Emscripten) | |||
| set(ENABLE_EMSCRIPTEN ON CACHE BOOL "Build for web with emscripten. Will also build the SDL2-based entrypoint." FORCE) | |||
| option(USE_PTHREADS "Enable pthreads" OFF) | |||
There was a problem hiding this comment.
You might consider adding a status message below if Emscripten and USE_PTHREADS is enabled to make it clear when configuring. No change necessary though.
There was a problem hiding this comment.
Okay I added a status message below!
Is this what you had in mind?
Blaquewithaq
force-pushed
the
add-pthreads-for-emscripten-only
branch
from
9348a5c to
2eb0a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back the USE_PTHREADS option for Emscripten builds only.
This flag is required in Emscripten builds to access certain features in the browser environment.