Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ninja package name in BUILDING.md #865

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

ianloic
Copy link
Contributor

@ianloic ianloic commented Jan 4, 2025

Debian and Ubuntu package the Ninja build system as ninja-build not ninja.

Debian and Ubuntu package the Ninja build system as `ninja-build` not `ninja`.
@kblaschke kblaschke self-requested a review January 5, 2025 18:24
@kblaschke kblaschke self-assigned this Jan 5, 2025
@kblaschke kblaschke added this to the 4.2 milestone Jan 5, 2025
@kblaschke
Copy link
Member

That has probably slipped through many edits, thanks for the heads-up! Will merge ASAP once the build checks allow me to ;)

@kblaschke kblaschke merged commit 1b7c7c8 into projectM-visualizer:master Jan 5, 2025
9 checks passed
@ianloic
Copy link
Contributor Author

ianloic commented Jan 5, 2025

So many of my open source contributions these days are:

  • follow instructions
  • instructions fail
  • patch instructions
  • send PR

I'll give you something better some day :-)

@kblaschke
Copy link
Member

Every little bit helps! Documentation often gets out of date, especially if there are many different files for the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants