Make translog_size_in_bytes a gauge #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Delaney <[email protected]>
sysadmind
approved these changes
Oct 15, 2023
jaimeyh
pushed a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
Signed-off-by: Aaron Delaney <[email protected]>
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
This reverts commit d2eb30a.
jaimeyh
added a commit
to sysdiglabs/elasticsearch_exporter
that referenced
this pull request
Jun 14, 2024
This reverts commit d2eb30a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grafana (and probably other tools) likes to encourage you to take rates of counters. However, In this case, it's invalid; translog_size_in_bytes does not only go up.
Using rate on this metric will likely lead to very wrong dashboards. rate() documentation includes a note: "rate should only be used with counters and native histograms where the components behave like counters"
I didn't check if other metrics have this property. Maybe there should be some effort to remove any instances where this happens?
I made this change with the github editor (because it's so minor) but that means I haven't run any tests. Is that OK?