Skip to content

stop logging errors on replicas, fixes #547 #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

saz
Copy link
Contributor

@saz saz commented Jun 20, 2024

This PR tries to fix all error messages, shown on replicas, I've stumbled upon.

It's based on #914, which can be closed with the merge of this PR

@roock
Copy link

roock commented Jun 21, 2024

additionally fixes #962

@saz
Copy link
Contributor Author

saz commented Jul 25, 2024

Any news on this one?

@dusatvoj
Copy link

Can someone please take a look at it? 🙏

@sysadmind / @SuperQ / @Sticksman / ?

@saz saz mentioned this pull request Aug 30, 2024
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysadmind sysadmind merged commit 98f75c7 into prometheus-community:master Sep 5, 2024
9 checks passed
@scanterog
Copy link

thanks! are you planning a new release soon?

@dusatvoj
Copy link

@sysadmind , are you able to do a release, please? 🙏 Missing this feature released

@tunbb
Copy link

tunbb commented Nov 15, 2024

additionally fixes #962
still occurs in pg 13 and exporter 15.0

@saz saz deleted the fix-errors-replica branch November 17, 2024 10:34
@saz
Copy link
Contributor Author

saz commented Nov 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants