Skip to content

Update for Prometheus Community #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Update for Prometheus Community #480

merged 1 commit into from
Feb 26, 2021

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Feb 19, 2021

Add standard Prometheus build setup

  • CircleCI config
  • Makefile
  • Go modules
  • Golang-CI Lint
  • promu config
  • Remove /vendor
  • Remove mage build
  • Update READMEs

#478

Fixes: #470

Signed-off-by: Ben Kochie [email protected]

@SuperQ SuperQ requested a review from wrouesnel February 19, 2021 10:04
@SuperQ
Copy link
Contributor Author

SuperQ commented Feb 19, 2021

After this is done, we can work on re-adding integration tests. We do similar things in the mysqld_exporter CircleCI config.

@SuperQ
Copy link
Contributor Author

SuperQ commented Feb 22, 2021

Ping @wrouesnel

@roidelapluie
Copy link

Can you please give a second pass at the README ? still mentions vendoring and mage.

Add standard Prometheus build setup
* CircleCI config
* Makefile
* Go modules
* Golang-CI Lint
* promu config
* Remove /vendor
* Remove mage build
* Update READMEs

#478

Signed-off-by: Ben Kochie <[email protected]>
@SuperQ
Copy link
Contributor Author

SuperQ commented Feb 23, 2021

Ok, I updated the README some more.

@SuperQ SuperQ requested a review from roidelapluie February 23, 2021 11:40
Copy link

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even think that we need to mention vendoring at all but LGTM.

@SuperQ SuperQ merged commit c1ddbee into master Feb 26, 2021
@SuperQ SuperQ deleted the superq/community branch February 26, 2021 13:59
ritbl pushed a commit to heniek/postgres_exporter that referenced this pull request Mar 19, 2023
…/superq/community

Update for Prometheus Community
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sha256sums.txt files with releases
2 participants