instrumentation: add internal metrics server #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
when stopping the program, the logs look like there are errors
^C2022/07/18 17:18:02 Server stopped with accept tcp [::]:8080: use of closed network connection
2022/07/18 17:18:02 Internal server stopped with accept tcp [::]:8081: use of closed network connection
2022/07/18 17:18:02 Server stopped with received signal interrupt
squat
force-pushed
the
internal_metrics_server
branch
from
30b969a to
a9f1745
Compare
|
Just tested locally and everything starts and stops as expected. HTTP metrics are now exposed :) |
There was a problem hiding this comment.
IIIUC closing the net listener logs an error from the HTTP server. We need to close the server instead.
2022/07/20 14:23:24 Listening insecurely on [::]:8080
2022/07/20 14:23:24 Listening on [::]:8081 for metrics and pprof
^C2022/07/20 14:23:24 Server stopped with accept tcp [::]:8080: use of closed network connection
2022/07/20 14:23:24 Internal server stopped with accept tcp [::]:8081: use of closed network connection
2022/07/20 14:23:24 Caught signal; exiting gracefully...
main.go
Outdated
| } | ||
| return nil | ||
| }, func(error) { | ||
| l.Close() |
There was a problem hiding this comment.
Suggested change
| l.Close() | |
| srv.Close() |
main.go
Outdated
Comment on lines
144
to
146
| g.Add(func() error { | ||
| log.Printf("Listening on %v for metrics and pprof", l.Addr()) | ||
| if err := http.Serve(l, h); err != nil && err != http.ErrServerClosed { |
There was a problem hiding this comment.
Suggested change
| g.Add(func() error { | |
| log.Printf("Listening on %v for metrics and pprof", l.Addr()) | |
| if err := http.Serve(l, h); err != nil && err != http.ErrServerClosed { | |
| srv := &http.Server{Handler: h} | |
| g.Add(func() error { | |
| log.Printf("Listening on %v for metrics and pprof", l.Addr()) | |
| if err := srv.Serve(l); err != nil && err != http.ErrServerClosed { |
main.go
Outdated
| } | ||
| return nil | ||
| }, func(error) { | ||
| l.Close() |
There was a problem hiding this comment.
Suggested change
| l.Close() | |
| srv.Close() |
This commit adds an internal server to the prom-label-proxy that exposes HTTP metrics about all of the routes registered with the prom-label-proxy. The internal server also exposes pprof profiles. The internal server is only activated if the --internal-listen-address flag is provided. Signed-off-by: Lucas Servén Marín <[email protected]>
squat
force-pushed
the
internal_metrics_server
branch
from
a9f1745 to
bdbb122
Compare
|
Yes, absolutely good point. Just cleaned this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an internal server to the prom-label-proxy that exposes
HTTP metrics about all of the routes registered with the
prom-label-proxy. The internal server also exposes pprof profiles. The
internal server is only activated if the --internal-listen-address flag
is provided.
Signed-off-by: Lucas Servén Marín [email protected]