-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add default Go runtime metrics for /gc/gogc:percent, /gc/gomemlimit:bytes, /sched/gomaxprocs:threads #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bwplotka
merged 17 commits into
prometheus:main
from
vesari:add-three-to-default-go-runtime-metrics
Aug 9, 2024
Merged
Add default Go runtime metrics for /gc/gogc:percent, /gc/gomemlimit:bytes, /sched/gomaxprocs:threads #1559
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
cd8445b
Add go_gomaxprocs, go_gogc_percent and go_gomemlimit to the default G…
vesari 5d64fb7
Move newly added metrics out of base metrics and into goCollector
vesari 17b3065
Rethink struct for newly added metrics, adapt and add tests
vesari 5d9b680
Simplify new metrics reading
vesari 4490f8d
Correct loop, add debugging lines
vesari fb0afbe
Make goRuntimeEnvVarsMetrics function Go version dependent
vesari 0b3a6f0
Fix go mod
vesari 6478f56
Remove debuggin line
vesari e4a5ade
Merge remote-tracking branch 'prometheus/main' into add-three-to-defa…
vesari a04c891
Merge remote-tracking branch 'prometheus/main' into add-three-to-defa…
vesari 20ebd6c
Move default runtime metrics into the runtime metrics flow, change te…
vesari ed4053d
Go version expected default runtime metrics map for tests
vesari b8a9eb7
1.21 update.
bwplotka 23879d6
Addressed comments on Arianna's PR.
bwplotka cd5a2a6
Merge pull request #1 from prometheus/newmetrics
vesari 5eb377e
Merge branch 'main' into add-three-to-default-go-runtime-metrics
vesari 4a2cb15
Use default GoCollector func in test
vesari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.