Add nested autocompletion that supports meta #1396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidVentura
force-pushed
the
nested-autocompletion-meta
branch
from
0b01417 to
f905d1a
Compare
DavidVentura
force-pushed
the
nested-autocompletion-meta
branch
from
4da89bb to
b87035a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I use the nested completer and been thinking about using metadata on it.
Couldn't really figure a way to cleanly incorporate a
meta_dictinto the existingNestedCompleterwithout duplicating all keys.I don't really like this implementation, but it seems like a good point to start a discussion.