Instantiate a Buffer that does not use undo and redo stacks #1465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that, under the current implementation, the undo stack gets appended a copy of the whole text at every new input, which results on unacceptable memory waste for my intended application, in which I plan to edit potentially large (up to 1MB) texts, and will handle undo/redo my own way.
My change simply consists in adding a
enable_undo_redo
parameter on the instantiation onBuffer
andPromptSession
(since it always creates its own internal buffer), and using it as a flag to prevent the stacks from being populated inBuffer.undo
,Buffer.redo
andBuffer.save_to_undo_stack
.