Use Object.hasOwnProperty instead of prototype method #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
approved these changes
Jun 24, 2019
|
Thanks @mhamrah! |
|
@alexander-fenster Is this going to be released anytime soon? |
|
@mbaranovski I don't have rights to release it, please ask @dcodeIO who is the owner of this library :) |
johncsnyder
pushed a commit
to johncsnyder/protobuf.js
that referenced
this pull request
Sep 21, 2019
pgherveou
pushed a commit
to pgherveou/protobuf.js
that referenced
this pull request
Mar 28, 2020
taylorcode
pushed a commit
to taylorcode/protobuf.js
that referenced
this pull request
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a situation uncovered with #1232 where the encode method calls
hasOwnPropertyof an object which may not have a prototype. This situation came about when mapping an express request to a grpc call, where aoneOfobject is a sub-message of a parent object. UsingObject.hasOwnProperty.callappears to a safer approach which doesn't make assumptions about the underlying object's inheritance.