Skip to content

Make Bazel rules usable in different workspaces. #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

PiotrSikora
Copy link
Member

  1. None of the Wasm runtimes we use provide native Bazel support, so
    use //external bindings to match exposed targets across different
    workspaces.

  2. Split runtime targets from the base library to allow consumers to
    create desired combination in their workspace.

Signed-off-by: Piotr Sikora [email protected]

@PiotrSikora PiotrSikora requested a review from mathetake as a code owner June 5, 2021 01:54
1. None of the Wasm runtimes we use provide native Bazel support, so
   use //external bindings to match exposed targets across different
   workspaces.

2. Split runtime targets from the base library to allow consumers to
   create desired combination in their workspace.

Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora
Copy link
Member Author

Envoy integration tested in envoyproxy/envoy#16828 (only envoyproxy/envoy@68c387f is relevant).

Copy link
Contributor

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora
Copy link
Member Author

@mathetake I've made a few more changes, PTAL if it still looks fine to you. Envoy PR at envoyproxy/envoy#16828.

@PiotrSikora PiotrSikora merged commit 605ee8a into proxy-wasm:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants