Make Bazel rules usable in different workspaces. #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. None of the Wasm runtimes we use provide native Bazel support, so use //external bindings to match exposed targets across different workspaces. 2. Split runtime targets from the base library to allow consumers to create desired combination in their workspace. Signed-off-by: Piotr Sikora <[email protected]>
|
Envoy integration tested in envoyproxy/envoy#16828 (only envoyproxy/envoy@68c387f is relevant). |
PiotrSikora
commented
Jun 5, 2021
PiotrSikora
commented
Jun 5, 2021
…build Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
Signed-off-by: Piotr Sikora <[email protected]>
|
@mathetake I've made a few more changes, PTAL if it still looks fine to you. Envoy PR at envoyproxy/envoy#16828. |
mathetake
reviewed
Jun 9, 2021
mathetake
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the Wasm runtimes we use provide native Bazel support, so
use //external bindings to match exposed targets across different
workspaces.
Split runtime targets from the base library to allow consumers to
create desired combination in their workspace.
Signed-off-by: Piotr Sikora [email protected]