fix: complete migration to ns8 and fix build issues

.github/issue_template.md

@@ -13,10 +13,10 @@ letter.
 
 ### Please, provide the following version numbers that your issue occurs with:
 
-- CLI: (run `tns --version` to fetch it)
+- CLI: (run `ns --version` to fetch it)
 - Cross-platform modules: (check the 'version' attribute in the
-`node_modules/tns-core-modules/package.json` file in your project)
-- Runtime(s): (look for the `"tns-android"` and `"tns-ios"` properties in the `package.json` file of your project)
+`node_modules/@nativescript/core/package.json` file in your project)
+- Runtime(s): (look for the `"@nativescript/android"` and `"@nativescript/ios"` properties in the `package.json` file of your project)
 - Plugin(s): (look for the version numbers in the `package.json` file of your
 project and paste your dependencies and devDependencies here)
 

.travis.yml

@@ -13,22 +13,22 @@ matrix:
       language: node_js 
       node_js: "10"
       jdk: oraclejdk8
-      script: cd src && npm run build && cd ../demo && npm i && tns build ios --bundle --env.uglify
+      script: cd src && npm run build && cd ../demo && npm i && ns build ios --bundle --env.uglify
     - language: android
       os: linux
       env:
         - WebPack="Android"
       jdk: oraclejdk8
       before_install: nvm install 10
-      script: cd src && npm run build && cd ../demo && npm i && tns build android --bundle --env.uglify --env.snapshot
+      script: cd src && npm run build && cd ../demo && npm i && ns build android --bundle --env.uglify --env.snapshot
     - language: android
       env: 
         - BuildAndroid="28"
       os: linux
       jdk: oraclejdk8
       before_install: nvm install 10
       script:
-        - cd src && npm i && npm run tsc && cd ../demo && tns build android
+        - cd src && npm i && npm run tsc && cd ../demo && ns build android
     - os: osx
       env: 
         - BuildiOS="12"
@@ -38,7 +38,7 @@ matrix:
       node_js: "10"
       jdk: oraclejdk8
       script: 
-        - cd src && npm i && npm run tsc && cd ../demo && tns build ios
+        - cd src && npm i && npm run tsc && cd ../demo && ns build ios
 
     # TODO: Include unit tests...
     # - os: linux
@@ -75,5 +75,5 @@ before_install:
 
 install:
     - echo no | npm install -g nativescript
-    - tns usage-reporting disable
-    - tns error-reporting disable
+    - ns usage-reporting disable
+    - ns error-reporting disable

README.md

@@ -47,7 +47,7 @@ Share your awesome project [here](https://github.com/proyecto26/nativescript-ina
 ## Getting started
 
 ```javascript
-tns plugin add nativescript-inappbrowser
+ns plugin add nativescript-inappbrowser
 ```
 
 ### Manual installation

demo/app/app.css

@@ -9,36 +9,36 @@ In many cases you may want to use the NativeScript core theme instead
 of writing your own CSS rules. For a full list of class names in the theme
 refer to http://docs.nativescript.org/ui/theme.
 */
-@import '~nativescript-theme-core/css/core.css';
+@import "nativescript-theme-core/css/core.css";
 
 TextField {
-    border-width: 1;
-    border-color: gray;
-    height: 45;
-    margin-top: 5;
-  }
-  
-  .content {
-    padding-left: 20;
-    padding-right: 20;
-  }
-  
-  .p {
-    font-size: 14;
-    color: #333333;
-    margin: 5;
-  }
-  
-  .my-button {
-    background-color: transparent;
-    border-radius: 5;
-    color: blue;
-    font-family: FontAwesome;
-    font-size: 18;
-    vertical-align: middle;
-    width: 80%;
-  }
-  
-  .my-button:active {
-    color:black;
-  }
+  border-width: 1;
+  border-color: gray;
+  height: 45;
+  margin-top: 5;
+}
+
+.content {
+  padding-left: 20;
+  padding-right: 20;
+}
+
+.p {
+  font-size: 14;
+  color: #333333;
+  margin: 5;
+}
+
+.my-button {
+  background-color: transparent;
+  border-radius: 5;
+  color: blue;
+  font-family: FontAwesome;
+  font-size: 18;
+  vertical-align: middle;
+  width: 80%;
+}
+
+.my-button:active {
+  color: black;
+}

demo/app/home/home-page.ts

@@ -1,9 +1,9 @@
-import { EventData, Page } from '@nativescript/core';
-import {HelloWorldModel} from './home-view-model';
+import { EventData, Page } from "@nativescript/core";
+import { HelloWorldModel } from "./home-view-model";
 
 // Event handler for Page 'loaded' event attached in main-page.xml
 export function pageLoaded(args: EventData) {
     // Get the event sender
     let page = <Page>args.object;
     page.bindingContext = new HelloWorldModel();
-}
+}

demo/app/home/home-page.xml

@@ -14,4 +14,4 @@
     <Button text="Open link" class="my-button btn" tap="{{ openLink }}"></Button>
     <Button text="Try deep linking" class="my-button btn" tap="{{ tryDeepLinking }}"></Button>
   </StackLayout>
-</Page>
+</Page>

demo/app/home/home-view-model.ts

@@ -1,110 +1,110 @@
-import { Observable, Utils, Dialogs } from '@nativescript/core';
-import { InAppBrowser } from 'nativescript-inappbrowser';
-import { getDeepLink, sleep } from './utilities';
+import { Observable, Utils, Dialogs } from "@nativescript/core";
+import { InAppBrowser } from "nativescript-inappbrowser";
+import { getDeepLink, sleep } from "./utilities";
 
 export class HelloWorldModel extends Observable {
-  private _url: string;
+    private _url: string;
 
-  constructor() {
-    super();
+    constructor() {
+        super();
 
-    // Initialize default values.
-    this._url = 'https://nativescript.org';
-  }
-
-  get url(): string {
-    return this._url;
-  }
+        // Initialize default values.
+        this._url = "https://nativescript.org";
+    }
 
-  set url(value: string) {
-    if (this._url !== value) {
-      this._url = value;
-      this.notifyPropertyChange('url', value);
+    get url(): string {
+        return this._url;
     }
-  }
 
-  async openLink() {
-    try {
-      const { url } = this;
-      if (await InAppBrowser.isAvailable()) {
-        const result = await InAppBrowser.open(url, {
-          // iOS Properties
-          dismissButtonStyle: 'cancel',
-          preferredBarTintColor: '#453AA4',
-          preferredControlTintColor: 'white',
-          readerMode: false,
-          animated: true,
-          modalPresentationStyle: 'fullScreen',
-          modalTransitionStyle: 'coverVertical',
-          modalEnabled: true,
-          enableBarCollapsing: false,
-          // Android Properties
-          showTitle: true,
-          toolbarColor: '#6200EE',
-          secondaryToolbarColor: 'black',
-          navigationBarColor: 'black',
-          navigationBarDividerColor: 'white',
-          enableUrlBarHiding: true,
-          enableDefaultShare: true,
-          forceCloseOnRedirection: true,
-          // Specify full animation resource identifier(package:anim/name)
-          // or only resource name(in case of animation bundled with app).
-          animations: {
-            startEnter: 'slide_in_right',
-            startExit: 'slide_out_left',
-            endEnter: 'slide_in_left',
-            endExit: 'slide_out_right'
-          },
-          headers: {
-            'my-custom-header': 'my custom header value'
-          },
-          hasBackButton: true,
-          browserPackage: '',
-          showInRecents: false
-        });
-        await sleep(800);
-        Dialogs.alert({
-          title: 'Response',
-          message: JSON.stringify(result),
-          okButtonText: 'Ok'
-        });
-      }
-      else {
-        Utils.openUrl(url);
-      }
+    set url(value: string) {
+        if (this._url !== value) {
+            this._url = value;
+            this.notifyPropertyChange("url", value);
+        }
     }
-    catch (error) {
-      Dialogs.alert({
-        title: 'Error',
-        message: error.message,
-        okButtonText: 'Ok'
-      });
+
+    async openLink() {
+        try {
+            const { url } = this;
+            if (await InAppBrowser.isAvailable()) {
+                const result = await InAppBrowser.open(url, {
+                    // iOS Properties
+                    dismissButtonStyle: "cancel",
+                    preferredBarTintColor: "#453AA4",
+                    preferredControlTintColor: "white",
+                    readerMode: false,
+                    animated: true,
+                    modalPresentationStyle: "fullScreen",
+                    modalTransitionStyle: "coverVertical",
+                    modalEnabled: true,
+                    enableBarCollapsing: false,
+                    // Android Properties
+                    showTitle: true,
+                    toolbarColor: "#6200EE",
+                    secondaryToolbarColor: "black",
+                    navigationBarColor: "black",
+                    navigationBarDividerColor: "white",
+                    enableUrlBarHiding: true,
+                    enableDefaultShare: true,
+                    forceCloseOnRedirection: true,
+                    // Specify full animation resource identifier(package:anim/name)
+                    // or only resource name(in case of animation bundled with app).
+                    animations: {
+                        startEnter: "slide_in_right",
+                        startExit: "slide_out_left",
+                        endEnter: "slide_in_left",
+                        endExit: "slide_out_right",
+                    },
+                    headers: {
+                        "my-custom-header": "my custom header value",
+                    },
+                    hasBackButton: true,
+                    browserPackage: "",
+                    showInRecents: false,
+                });
+                await sleep(800);
+                Dialogs.alert({
+                    title: "Response",
+                    message: JSON.stringify(result),
+                    okButtonText: "Ok",
+                });
+            } else {
+                Utils.openUrl(url);
+            }
+        } catch (error) {
+            Dialogs.alert({
+                title: "Error",
+                message: error.message,
+                okButtonText: "Ok",
+            });
+        }
     }
-  }
 
-  async tryDeepLinking() {
-    const loginUrl = `https://proyecto26.github.io/react-native-inappbrowser`;
-    const redirectUrl = getDeepLink('home');
-    const url = `${loginUrl}?redirect_url=${encodeURIComponent(redirectUrl)}`;
-    try {
-      if (await InAppBrowser.isAvailable()) {
-        const result = await InAppBrowser.openAuth(url, redirectUrl, {
-          // iOS Properties
-          ephemeralWebSession: true,
-          // Android Properties
-          showTitle: false,
-          enableUrlBarHiding: true,
-          enableDefaultShare: true
-        });
-        await sleep(800);
-        Dialogs.alert({
-          title: 'Response',
-          message: JSON.stringify(result),
-          okButtonText: 'Ok'
-        });
-      }
-    } catch {
-      Dialogs.alert('Something’s wrong with the app :(');
+    async tryDeepLinking() {
+        const loginUrl = `https://proyecto26.github.io/react-native-inappbrowser`;
+        const redirectUrl = getDeepLink("home");
+        const url = `${loginUrl}?redirect_url=${encodeURIComponent(
+            redirectUrl
+        )}`;
+        try {
+            if (await InAppBrowser.isAvailable()) {
+                const result = await InAppBrowser.openAuth(url, redirectUrl, {
+                    // iOS Properties
+                    ephemeralWebSession: true,
+                    // Android Properties
+                    showTitle: false,
+                    enableUrlBarHiding: true,
+                    enableDefaultShare: true,
+                });
+                await sleep(800);
+                Dialogs.alert({
+                    title: "Response",
+                    message: JSON.stringify(result),
+                    okButtonText: "Ok",
+                });
+            }
+        } catch {
+            Dialogs.alert("Something’s wrong with the app :(");
+        }
     }
-  }
 }

demo/app/home/utilities.ts

@@ -1,9 +1,9 @@
 export const getDeepLink = (path = "") => {
-  const scheme = 'my-demo';
-  const prefix = global.isAndroid ? `${scheme}://demo/` : `${scheme}://`;
-  return prefix + path;
+    const scheme = "my-demo";
+    const prefix = global.isAndroid ? `${scheme}://demo/` : `${scheme}://`;
+    return prefix + path;
 };
 
 export const sleep = (timeout: number) => {
-  return new Promise(resolve => setTimeout(resolve, timeout));
-};
+    return new Promise((resolve) => setTimeout(resolve, timeout));
+};