-
Notifications
You must be signed in to change notification settings - Fork 27
(PDS-380) Add Inconsolata as monospace font #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR proposes adding |
Yeah I vote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Love that we have a Code
component now. I think that'll be handy if we end up wanting to add props for a bordered code block or something. I left a couple comments about the docs.
I'm not sure why the x-height is taller when I view this in Styleguidist when compared to https://fonts.google.com/specimen/Inconsolata. Here are my screenshots:
Inconsolata on fonts.google.com:
Inconsolata example in Styleguidist:
My eye caught the fact that it looks a bit stretched out vertically, so maybe we can do a little more investigation to try to figure out why that's happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves PDS-380