Add multiselect functionality to select component #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jilliankeenan
commented
Jan 3, 2020
jilliankeenan
commented
- https://tickets.puppetlabs.com/browse/PDS-333
nmuldavin
suggested changes
Jan 6, 2020
packages/react-components/source/react/library/select/Select.js
Outdated
Show resolved
Hide resolved
packages/react-components/source/react/library/select/Select.md
Outdated
Show resolved
Hide resolved
|
|
||
| if (type !== MULTISELECT) { | ||
| this.closeAndFocusButton(); | ||
| } |
There was a problem hiding this comment.
I'm curious, what was the behavior you were trying to enable (or prevent) by adding this?
There was a problem hiding this comment.
I found that the select component with no type specified (if this is not in) it will not close the dropdown option list and therefore the user is able to select multiple options from the dropdown. This is acting as a catch-all to say if it isn't multi-select then close the drop down option list after one option from the list has been selected. Hope that makes sense!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.