Skip to content

Fix and add custom width to ActionSelect and ButtonSelect #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2020
Merged

Fix and add custom width to ActionSelect and ButtonSelect #199

merged 4 commits into from
Jan 23, 2020

Conversation

rhyza
Copy link
Contributor

@rhyza rhyza commented Jan 22, 2020 •
edited
Loading

Resolves PDS-416

  • Add custom width to ActionSelect
  • Add custom width to ButtonSelect
  • Fix issue where the ActionSelect shifts a pixel to the right when active
  • Fix issue where the ButtonSelect shifts a pixel to the right when active

@rhyza rhyza requested a review from a team as a code owner January 22, 2020 21:51
@rhyza rhyza changed the title (WIP) Fix and add custom width to ActionSelect and ButtonSelect Fix and add custom width to ActionSelect and ButtonSelect Jan 22, 2020
@rhyza rhyza requested a review from vine77 January 23, 2020 01:14
vine77
vine77 approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@vine77 vine77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @rhyza! Thank you.

@rhyza rhyza merged commit 31bd2f7 into master Jan 23, 2020
@rhyza rhyza deleted the pds-416-buttonselect-width-prop branch January 23, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vine77 vine77 vine77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhyza @vine77