Add Cancel button to OptionMenuList #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vine77
suggested changes
Jan 24, 2020
There was a problem hiding this comment.
The description of PDS-335 should have been written better, but the "Cancel" button was intended to only show up in the case that applyImmediately is false, i.e. "Apply" and "Cancel" will show up together, but if there is a "Done" button (when applyImmediately is true), then there is no need for a "Cancel" button (since it doesn't actually undo the selections).
Also, if there's an easy way to increase the min-width of the dropdown just a little bit, that might be helpful:
packages/react-components/source/scss/library/components/_menu-list.scss
Outdated
Show resolved
Hide resolved
packages/react-components/source/react/internal/option-menu-list/OptionMenuList.js
Outdated
Show resolved
Hide resolved
vine77
suggested changes
Jan 25, 2020
packages/react-components/source/scss/library/components/_button-select.scss
Outdated
Show resolved
Hide resolved
vine77
force-pushed
the
pds-335-multiselect-cancel-button
branch
from
448e83d to
eabe3dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves PDS-335
Affects multiselect menus for ButtonSelect and Select/FormSelect.